RFR: 8316641: VarHandle template classes can share code in the base class [v2]

Jorn Vernee jvernee at openjdk.org
Thu Sep 21 13:53:44 UTC 2023


On Thu, 21 Sep 2023 08:50:00 GMT, Chen Liang <liach at openjdk.org> wrote:

>> VarHandle implementations have many static fields and methods that can be pulled to the common superclass to avoid repeated initialization and code duplication.
>> 
>> In addition, the Unsafe-based Buffer field access are replaced by usage of public methods or JavaNioAccess.
>
> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   byte array var handles can share a common base class

The X-VarHandleSegmentView.java.template and VarHandleSegmentViewBase.java files have diverged in the panama-foreign repo. Please break out the changes to those files and submit them to the panama-foreign repo instead. This will avoid having to resolve merge conflicts in the changed code.

Alternatively, you could make a PR for those changes in this repo that is dependent on the [JEP patch for 22](https://github.com/openjdk/jdk/pull/15103), which also contain the changes.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15854#issuecomment-1729628087


More information about the core-libs-dev mailing list