RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v40]
Srinivas Vamsi Parasa
duke at openjdk.org
Thu Sep 21 18:37:50 UTC 2023
On Thu, 21 Sep 2023 09:32:18 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> Srinivas Vamsi Parasa has updated the pull request incrementally with one additional commit since the last revision:
>>
>> change variable names of indexPivot* to pivotIndex*
>
> make/modules/java.base/Lib.gmk line 240:
>
>> 238:
>> 239: ifeq ($(call isTargetOs, linux)+$(call isTargetCpu, x86_64)+$(INCLUDE_COMPILER2), true+true+true)
>> 240: ifeq ($(TOOLCHAIN_TYPE), gcc)
>
> This requirement can be folded into the "and" sequence in the `ifeq` statement above. There is nothing that really merits it to be specified separately.
Hello Magnus (@magicus),
As suggested, made the modification to use a single `ifeq` (which works for me on a Linux machine). Could you please confirm if the approach below is correct?
`ifeq ($(call isTargetOs, linux)+$(call isTargetCpu, x86_64)+$(INCLUDE_COMPILER2)+$(filter $(TOOLCHAIN_TYPE), gcc), true+true+true+gcc)`
Thanks,
Vamsi
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14227#discussion_r1333450204
More information about the core-libs-dev
mailing list