RFR: 8316456: StackWalker may skip Continuation::yield0 frame mistakenly [v2]
Mandy Chung
mchung at openjdk.org
Thu Sep 21 20:11:12 UTC 2023
On Thu, 21 Sep 2023 19:29:30 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:
>> Mandy Chung has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>>
>> - Merge branch 'master' of https://github.com/openjdk/jdk into JDK-8316456
>> - call setBatch to update origin and fence for an empty batch
>> - 8316456: StackWalker may skip Continuation::yield0 frame mistakenly
>
> src/hotspot/share/prims/stackwalk.cpp line 189:
>
>> 187: // skip hidden frames for default StackWalker option (i.e. SHOW_HIDDEN_FRAMES
>> 188: // not set) and when StackWalker::getCallerClass is called
>> 189: LogTarget(Debug, stackwalk) lt;
>
> Nit, leftover.
Thanks for the review. Will clean up before it's integrated
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15804#discussion_r1333551895
More information about the core-libs-dev
mailing list