RFR: 8316540: StoreReproducibilityTest fails on some locales [v3]

Jaikiran Pai jpai at openjdk.org
Fri Sep 22 07:08:14 UTC 2023


On Thu, 21 Sep 2023 18:51:50 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Fixing a test case that fails in some time zones. Making sure the test is run in `UTC` zone will fix the issue. Confirmed the fix by manually setting machine's time zone to Europe/Dublin.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use createTestJvm for vm invocation

The difference between `createJavaProcessBuilder()` and `createTestJvm()` appears to be that additionally `test.vm.opts` and `test.java.opts` system properties get prefixed to the opts that are passed for the process creation. That looks fine to me, for this test. 

The current state of this PR in `bd786b92` looks good to me. Thank you Naoto for the updates.

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15829#pullrequestreview-1639276171


More information about the core-libs-dev mailing list