RFR: 8316150: Refactor get chars and string size [v6]

ExE Boss duke at openjdk.org
Fri Sep 22 08:22:12 UTC 2023


On Fri, 22 Sep 2023 07:19:27 GMT, 温绍锦 <duke at openjdk.org> wrote:

>> 1. Reduce duplicate stringSize code
>> 2. Move java.lang.StringLatin1.getChars to jdk.internal.util.DecimalDigits::getCharLatin1,not only java.lang, other packages also need to use this method
>
> 温绍锦 has updated the pull request incrementally with one additional commit since the last revision:
> 
>   restore HexDigits & OctalDigits

src/java.base/share/classes/java/util/FormatItem.java line 277:

> 275:             this.hasPrefix = hasPrefix;
> 276:             this.value = value;
> 277:             this.length = HexDigits.INSTANCE.size(value);

Suggestion:

            this.length = OctalDigits.INSTANCE.size(value);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15699#discussion_r1334053601


More information about the core-libs-dev mailing list