RFR: 8316000: File.setExecutable silently fails if file does not exist [v4]

Brian Burkhalter bpb at openjdk.org
Fri Sep 22 22:46:43 UTC 2023


On Thu, 21 Sep 2023 08:32:21 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8316000: Move apiNotes to normative text; update @return descriptions
>
> src/java.base/share/classes/java/io/File.java line 1643:
> 
>> 1641:      *          change the access permissions of this abstract pathname.  If
>> 1642:      *          the underlying file system does not implement a read permission,
>> 1643:      *          then the operation will return the value of the {@code readable}
> 
> There's a switcharoo here. The method description speaks of the platform not supporting file permissions. The return description changes terminology and speaks of the file system not implementating permissions. I think we'll get these consistent but overall the intent is okay.

Reconciled these in 8189784ace0a693a042f86505466806377684f80.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15673#discussion_r1334866057


More information about the core-libs-dev mailing list