RFR: JDK-8316897: tools/jpackage/junit tests fail on AIX after JDK-8316547

Jaikiran Pai jpai at openjdk.org
Tue Sep 26 10:04:12 UTC 2023


On Tue, 26 Sep 2023 09:53:08 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> AIX currently does not have the jdk.jpackage system module. We have to take this into account for these jpackage tests.
>
> test/jdk/tools/jpackage/junit/jdk.jpackage/jdk/jpackage/internal/AppImageFileTest.java line 26:
> 
>> 24: /*
>> 25:  * @test
>> 26:  * @modules jdk.jpackage
> 
> Hello Matthias,
> 
> Would moving `@modules jdk.jpackage` to `test/jdk/tools/jpackage/junit/TEST.properties` like the following:
> 
> 
> modules=jdk.jpackage
> 
> 
> and adding the `@test` declaration to these  tests, get this passing on AIX? That way it will avoid the repeated `@modules` declaration in these test files.

Christian noted that the `@test` in each of the test files may not even be needed if you could just add the `modules=jdk.jpackage` to the existing content of `TEST.properties` file.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15916#discussion_r1336964564


More information about the core-libs-dev mailing list