RFR: 8316879: RegionMatches1Tests fails if CompactStrings are disabled after JDK-8302163 [v4]
Roger Riggs
rriggs at openjdk.org
Tue Sep 26 16:27:15 UTC 2023
On Tue, 26 Sep 2023 16:18:09 GMT, Aleksei Voitylov <avoitylov at openjdk.org> wrote:
>> test java.lang.String.RegionMatches1Tests fails on all platforms with -XX:-CompactStrings option and on ARM32 where Compact Strings is disabled by default. The fix is to return true immediately if len is negative, since for negative length this condition will never be satisfied.
>>
>> Testing: JCK, JTREG passed with the fix with -XX:-CompactStrings on x86_64 and on ARM32.
>
> Aleksei Voitylov has updated the pull request incrementally with one additional commit since the last revision:
>
> address review comments
> test/jdk/java/lang/String/RegionMatches.java was converted to testng and split into two @tests, the latter now covers 8316879.
Can the test use JUnit 5? JUnit is being maintained compared to TestNG.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15906#issuecomment-1735880178
More information about the core-libs-dev
mailing list