RFR: 8316879: RegionMatches1Tests fails if CompactStrings are disabled after JDK-8302163 [v5]
Raffaello Giulietti
rgiulietti at openjdk.org
Wed Sep 27 13:09:14 UTC 2023
On Wed, 27 Sep 2023 09:58:58 GMT, Aleksei Voitylov <avoitylov at openjdk.org> wrote:
>> test java.lang.String.RegionMatches1Tests fails on all platforms with -XX:-CompactStrings option and on ARM32 where Compact Strings is disabled by default. The fix is to return true immediately if len is negative, since for negative length this condition will never be satisfied.
>>
>> Testing: JCK, JTREG passed with the fix with -XX:-CompactStrings on x86_64 and on ARM32.
>
> Aleksei Voitylov has updated the pull request incrementally with one additional commit since the last revision:
>
> address review comments
It avoids the two `String` constructor invocations, otherwise it is as (badly) readable as with the `byte[]`.
My question was just curiosity.
The best thing would be to use `"нажд"` and `"в ст"`, but AFAIK that's not allowed in OpenJDK.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15906#issuecomment-1737365014
More information about the core-libs-dev
mailing list