RFR: 8316426: Optimization for HexFormat.formatHex [v8]

Wed Sep 27 13:39:15 UTC 2023

On Wed, 27 Sep 2023 09:07:44 GMT, 温绍锦 <duke at openjdk.org> wrote:

>> In the improvement of @cl4es PR #15591, the advantages of non-lookup-table were discussed.
>> 
>> But if the input is byte[], using lookup table can improve performance.
>> 
>> For HexFormat#formatHex(Appendable, byte[]) and HexFormat#formatHex(byte[]), If the length of byte[] is larger, the performance of table lookup will be improved more obviously.
>
> 温绍锦 has updated the pull request incrementally with one additional commit since the last revision:
> 
>   reduce the size of HexFormat##DIGITS, from 256 to 128

It is conventional to get re-reviews of any change and give the reviewers that taken the time to review the PR a chance to review any subsequent changes.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15768#issuecomment-1737413165