RFR: 8316879: RegionMatches1Tests fails if CompactStrings are disabled after JDK-8302163 [v5]

Aleksei Voitylov avoitylov at openjdk.org
Wed Sep 27 14:13:09 UTC 2023


On Wed, 27 Sep 2023 13:27:10 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Aleksei Voitylov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   address review comments
>
> test/jdk/java/lang/String/RegionMatches.java line 41:
> 
>> 39: 
>> 40:   private final byte[] b1_UTF16 = new byte[]{0x04, 0x3d, 0x04, 0x30, 0x04, 0x36, 0x04, 0x34};
>> 41:   private final byte[] b2_UTF16 = new byte[]{0x04, 0x32, 0x00, 0x20, 0x04, 0x41, 0x04, 0x42};
> 
> For strings, the \uxxxx version would be preferred; it is clearer that what the character is and there is less of a chance that the UTF encoding has a mistake.

Done!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15906#discussion_r1338669536


More information about the core-libs-dev mailing list