RFR: 8316970: Add internal annotation to mark restricted methods [v2]

Jorn Vernee jvernee at openjdk.org
Wed Sep 27 17:29:30 UTC 2023


On Wed, 27 Sep 2023 17:23:48 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> This patch adds a new internal annotation that is used to mark all restricted me
>> thods in the FFM API. The new annotation is similar to the one we used for preview API methods.
>> 
>> We plan to use the new annotation for adding new javac warnings when calling restricted methods, as well as to add better javadoc support for restricted methods.
>> 
>> I have added a test which, similar to the test for `@CallerSensitive` checks all methods in `java.base` that are annotated with `@Restricted` and makes sure they conform to the list of restricted methods.
>
> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Drop requires tag from test

Marked as reviewed by jvernee (Reviewer).

test/jdk/java/foreign/TestRestricted.java line 27:

> 25:  * @test
> 26:  * @enablePreview
> 27:  * @requires jdk.foreign.linker != "UNSUPPORTED"

FWIW, this `@requires` should not be needed since this test doesn't call `Linker.nativeLinker`

-------------

PR Review: https://git.openjdk.org/jdk/pull/15947#pullrequestreview-1647215073
PR Review Comment: https://git.openjdk.org/jdk/pull/15947#discussion_r1338954178


More information about the core-libs-dev mailing list