RFR: JDK-8316696: Remove the testing base classes: IntlTest and CollatorTest
Justin Lu
jlu at openjdk.org
Thu Sep 28 01:11:08 UTC 2023
Please review this PR which removes the i18n related testing base classes `IntlTest` and `CollatorTest` and converts all the tests that use them,
IntlTest and CollatorTest are testing classes which are extended by tests in `text/`, `util/Locale`, `util/TimeZone`, and `util/Calendar`. The abstract testing classes are quite dated and have caused issues such as: variation between OS, hiding stack trace, and causing tests to spuriously pass.
This change mainly automates a low level conversion of all the tests (75) using the frameworks; all tests were converted to use JUnit instead. (With the exception of `DateFormatRoundTripTest` due to the nature of the test).
The main changes can be viewed in the following commits
scripted changes - [c0ece01 ](https://github.com/openjdk/jdk/commit/c0ece01e91479a020d5c6dce937dc827472b763b)
- Converts the IntlTest methods logln, log, err, and errln
- Adds the JUnit Test annotation to tests that should be ran
- Adjusts the Jtreg tags accordingly
- Remove the main method
- Insert initAll() methods for tests that previously adjusted the JVM default Locale/TimeZone in the main method
manual changes - [9a54910](https://github.com/openjdk/jdk/commit/9a5491065a94a4dc7a05194f3b8330efba8077b7)
- Some tests that had extensive logic in the main method or did not follow the general IntlTest format had to be manually adjusted
- Also clarified some tests that had optional argument setup in the main method (now removed)
removal of IntlTest and CollatorTest - [8ee9f9c](https://github.com/openjdk/jdk/commit/8ee9f9c79f79210ee6244186970d87a1cac05556)
- Removes both the test classes.
- Replaces CollatorTest with CollatorUtils
-------------
Commit messages:
- remove IntlTest and CollatorTest. introduce CollatorUtils
- manual changes
- scripted changes
Changes: https://git.openjdk.org/jdk/pull/15954/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15954&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8316696
Stats: 4295 lines in 79 files changed: 930 ins; 910 del; 2455 mod
Patch: https://git.openjdk.org/jdk/pull/15954.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/15954/head:pull/15954
PR: https://git.openjdk.org/jdk/pull/15954
More information about the core-libs-dev
mailing list