RFR: 8316150: Refactor get chars and string size [v21]
温绍锦
duke at openjdk.org
Thu Sep 28 22:06:27 UTC 2023
On Sun, 24 Sep 2023 02:46:38 GMT, 温绍锦 <duke at openjdk.org> wrote:
>> 1. Reduce duplicate stringSize code
>> 2. Move java.lang.StringLatin1.getChars to jdk.internal.util.DecimalDigits::getCharLatin1,not only java.lang, other packages also need to use this method
>
> 温绍锦 has updated the pull request incrementally with one additional commit since the last revision:
>
> restore StringUTF16.getChars(int,int,int,byte[]) and StringUTF16.getChars(long,int,int,byte[])
There are too many changes that need to be made to reduce the duplication of code in the digits method and the getCharsLatin1.
Can we temporarily allow duplicate code for digits and getCharLatin1? Revert changes related to FormatItem. After this PR is completed, submit a new PR to change FormatItem and reduce duplicate code.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15699#issuecomment-1740061373
More information about the core-libs-dev
mailing list