RFR: 8317141: Remove unused validIndex method from URLClassPath$JarLoader

Daniel Fuchs dfuchs at openjdk.org
Fri Sep 29 11:06:18 UTC 2023


On Fri, 29 Sep 2023 05:41:11 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which removes unused (internal) method from the `private` `URLClassPath$JarLoader`? 
> 
> The `validIndex` method which is being removed here was being used when JAR index was supported. We removed support for JAR index in https://bugs.openjdk.org/browse/JDK-8302819. This method is now a leftover and no longer used.
> 
> The commit in this PR also removes a couple of other member fields in `URLClassPath$JarLoader`. These fields too were used previously when JAR index was in use and are no longer used.
> 
> tier1, tier2 and tier3 tests continue to pass with this change.

Looks reasonable to me.

-------------

Marked as reviewed by dfuchs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15976#pullrequestreview-1650562494


More information about the core-libs-dev mailing list