RFR: 8329099: Undocumented exception thrown by Instruction factory methods accepting Opcode [v2]

Adam Sotona asotona at openjdk.org
Wed Apr 3 10:06:31 UTC 2024


> `IllegalArgumentException` thrown by some static factory methods of the following `java.lang.classfile.instruction` interfaces are not documented:
> 
> - `ArrayLoadInstruction`
> - `ArrayStoreInstruction`
> - `BranchInstruction`
> - `ConvertInstruction`
> - `DiscontinuedInstruction`
> - `FieldInstruction`
> - `InvokeInstruction`
> - `LoadInstruction`
> - `MonitorInstruction`
> - `NewPrimitiveArrayInstruction`
> - `OperatorInstruction`
> - `ReturnInstruction`
> - `StackInstruction`
> - `StoreInstruction`
> - `TypeCheckInstruction`
> 
> `NewPrimitiveArrayInstruction::of` factory method also does not perform the check for invalid argument.
> 
> This patch adds all the missing `@throws` Javadoc tags and fixes `NewPrimitiveArrayInstruction::of` factory method to perform the argument check.
> 
> Please review.
> 
> Thank you,
> Adam

Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:

  Apply suggestions from code review
  
  Co-authored-by: ExE Boss <3889017+ExE-Boss at users.noreply.github.com>

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18578/files
  - new: https://git.openjdk.org/jdk/pull/18578/files/185dda1a..68949904

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18578&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18578&range=00-01

  Stats: 3 lines in 1 file changed: 1 ins; 1 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18578.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18578/head:pull/18578

PR: https://git.openjdk.org/jdk/pull/18578


More information about the core-libs-dev mailing list