RFR: JDK-8329624: Add visitors for preview language features

Vicente Romero vromero at openjdk.org
Wed Apr 3 21:36:00 UTC 2024


On Wed, 3 Apr 2024 20:17:39 GMT, Joe Darcy <darcy at openjdk.org> wrote:

> When new language features are added, the javax.lang.model may need to be updated. For certain classes of features, the API update includes introducing a new set of concrete visitors to handle the language feature.
> 
> The API scaffolding to support the new feature tends to be considerably larger than the API specifically for the new feature.
> 
> To aid work in progress (such as https://github.com/openjdk/jdk/pull/18509) and anticipated in the future, I think it would be helpful to introduce a persistent set of preview visitors independent of any particular language change.

looks good

src/java.compiler/share/classes/javax/lang/model/util/SimpleElementVisitorPreview.java line 2:

> 1: /*
> 2:  * Copyright (c) 2019, 2024, Oracle and/or its affiliates. All rights reserved.

general, please check the copyright years

-------------

Marked as reviewed by vromero (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18609#pullrequestreview-1978047611
PR Review Comment: https://git.openjdk.org/jdk/pull/18609#discussion_r1550497836


More information about the core-libs-dev mailing list