RFR: JDK-8319678: Several tests from corelibs areas ignore VM flags [v2]

Mahendra Chhipa mchhipa at openjdk.org
Thu Apr 4 17:16:22 UTC 2024


On Wed, 3 Apr 2024 20:08:04 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Implemented review comments.
>>   Updated EscapePath test.
>
> test/jdk/java/time/nontestng/java/time/chrono/HijrahConfigTest.java line 71:
> 
>> 69:         // Run tests
>> 70:         Path launcher = outputPath.resolve("bin").resolve("java");
>> 71:         OutputAnalyzer analyzer =  ProcessTools.executeCommand(launcher.toAbsolutePath().toString(),"-ea", "-esa", "HijrahConfigCheck");
> 
> Nit: need a space before `"-ea"`

Thanks, updated in next commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18602#discussion_r1552108497


More information about the core-libs-dev mailing list