RFR: 8324651: Compiler Implementation for Derived Record Creation (Preview) [v5]

[Jan Lahoda]

On Thu, 4 Apr 2024 17:00:33 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixing tests.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/main/JavaCompiler.java line 1574:
> 
>> 1572:             @Override
>> 1573:             public void visitDerivedInstance(JCDerivedInstance tree) {
>> 1574:                 hasPatterns |= true;
> 
> it could be thought as a pattern but it is not a pattern nor it is internally converted to a pattern, unless I'm missing something

The main point here is to make not run `TransPatterns` in case the visitor is not performing any work (because loading the class causes some perf tests to regress - we do the same for `LambdaToMethod`). But, as the desugaring was moved to `Lower`, we no longer need to do anything in `JavaCompiler`. Thanks for the comment!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18509#discussion_r1553555861