RFR: 8324651: Compiler Implementation for Derived Record Creation (Preview) [v7]

Mon Apr 8 14:06:13 UTC 2024

On Fri, 5 Apr 2024 18:28:58 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Lower.java line 4443:
>> 
>>> 4441:     }
>>> 4442: 
>>> 4443:     @Override
>> 
>> As usual, I suggest to add some brief comment with the shape of the generated code.
>
> Done here:
> https://github.com/openjdk/jdk/pull/18509/commits/146513580f96abd5feb7886bd1191805cc93403b#diff-bc0df6dce7f74078bfca1e90bec75d7bb3d8b338933be725da78f0a8a7a0c78dR4445
> 
> Please let me know if that needs some tweaks.
> 
> Thanks for the comment!

Looks great!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18509#discussion_r1555902226