Integrated: 8325485: IncrementInstructions.of(int, int) is not storing the args

Adam Sotona asotona at openjdk.org
Tue Apr 9 11:11:20 UTC 2024


On Thu, 8 Feb 2024 13:18:41 GMT, Adam Sotona <asotona at openjdk.org> wrote:

> ClassFile API provides two sets of instructions implementations (bound and unbound).
> Unbound implementation of `IncrementInstruction::constant` returns invalid value. 
> This bug discovered a hole in the ClassFile API test coverage.
> 
> This patch provides very simple fix of `IncrementInstruction`
> and more complex fix of the test framework to cover all unbound instruction with automated tests.
> 
> The test framework fix includes correction of hash calculation of instructions in `ClassRecord` and
> two-pass transformation in `RebuildingTransformation`. Second pass has been added to discover bugs in unbound-to-unbound instruction conversions.
> 
> Please review.
> 
> Thanks,
> Adam

This pull request has now been integrated.

Changeset: 8907eda7
Author:    Adam Sotona <asotona at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/8907eda779f0c3f870bb31deb74c0a483251f1e2
Stats:     786 lines in 4 files changed: 391 ins; 379 del; 16 mod

8325485: IncrementInstructions.of(int, int) is not storing the args

Reviewed-by: liach, jlahoda

-------------

PR: https://git.openjdk.org/jdk/pull/17770


More information about the core-libs-dev mailing list