RFR: 8329948: Remove string template feature [v3]

[Maurizio Cimadamore]

On Tue, 9 Apr 2024 20:22:34 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert StringConcatFactory field to before string template
>
> src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java line 120:
> 
>> 118:      * @since 21
>> 119:      */
>> 120:     public static final int MAX_INDY_CONCAT_ARG_SLOTS;
> 
> May this value change in the future? If yes, we might change this to a method to avoid incorrect eager inlining by the java compiler, or drop this with string templates.

Good catch. Since this was tweaked to be a public API as part of the string template feature, I've reverted this code to what it was prior to string template. That is, now this is a private static final constant, with initializer set to 200 (no need to inhibit javac constant folding, since all uses are from this file).

> src/java.base/share/classes/jdk/internal/util/OctalDigits.java line 44:
> 
>> 42:  *
>> 43:  * @since 21
>> 44:  */
> 
> Spurious javadoc

fixed, thanks

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18688#discussion_r1559228274
PR Review Comment: https://git.openjdk.org/jdk/pull/18688#discussion_r1559228920