RFR: JDK-8319678: Several tests from corelibs areas ignore VM flags [v2]

Jaikiran Pai jpai at openjdk.org
Wed Apr 10 11:00:13 UTC 2024


On Wed, 10 Apr 2024 10:45:55 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Implemented review comments.
>>   Updated EscapePath test.
>
> test/jdk/javax/naming/spi/providers/InitialContextTest.java line 286:
> 
>> 284:             OutputAnalyzer outputAnalyzer = ProcessTools.executeCommand(commands.toArray(new String[commands.size()]));
>> 285:             if(outputAnalyzer.getExitValue() != 0) {
>> 286:                 throw new RuntimeException(outputAnalyzer.getOutput());
> 
> Same comment as above `outputAnalyzer.shouldHaveExitValue(0)` would be better.

Applies to some other files in this PR as well.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18602#discussion_r1559242406


More information about the core-libs-dev mailing list