RFR: 8328481: Implement Module Imports [v4]

[Jan Lahoda]

On Wed, 10 Apr 2024 11:52:31 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adding more tests for ambiguities.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/tree/JCTree.java line 719:
> 
>> 717:     public static class JCModuleImport extends JCImportBase {
>> 718:         /** The module name. */
>> 719:         public JCExpression module;
> 
> Does it need to be an expression? Or is a name enough?

Expression is more consistent with e.g. the module directives (`JCRequires` has `JCExpression moduleName`). Also allows us to keep positions for the name.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18614#discussion_r1559440577