RFR: 8326227: Rounding error that may distort computeNextGaussian results [v3]
Chris Hennick
duke at openjdk.org
Thu Apr 11 01:07:50 UTC 2024
On Wed, 21 Feb 2024 02:18:08 GMT, Chris Hennick <duke at openjdk.org> wrote:
>> This provides a slightly more accurate bounding limit for `computeNextExponentialSoftCapped` when calling it from `computeNextGaussian`. This could cause the `while (computeNextExponentialSoftCapped(rng, limit) < limit)` check in `computeNextGaussian` on line 1402 to always be true, making the `nextGaussian` runtime unbounded in the worst case; but more likely, it would give a result that was truncated too close to zero.
>>
>> This change is being tested prior to submission to OpenJDK by https://github.com/openjdk/jdk/pull/17703/commits/b8be051cbf40a6a05fafc6a2c76942e9e0b11fdf.
>
> Chris Hennick has updated the pull request incrementally with one additional commit since the last revision:
>
> Bug fix: add-exports was for wrong package
Keep open
On Wed, Apr 10, 2024, 17:40 bridgekeeper[bot] ***@***.***>
wrote:
> @Pr0methean <https://github.com/Pr0methean> This pull request has been
> inactive for more than 4 weeks and will be automatically closed if another
> 4 weeks passes without any activity. To avoid this, simply add a new
> comment to the pull request. Feel free to ask for assistance if you need
> help with progressing this pull request towards integration!
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/openjdk/jdk/pull/17703#issuecomment-2048653656>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABF3NBOYVF4MBMKJ4FQBGIDY4XLYLAVCNFSM6AAAAABCZOX3UOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBYGY2TGNRVGY>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17703#issuecomment-2048715593
More information about the core-libs-dev
mailing list