RFR: 8319678: Several tests from corelibs areas ignore VM flags [v3]

Jaikiran Pai jpai at openjdk.org
Thu Apr 11 09:31:44 UTC 2024


On Thu, 11 Apr 2024 09:07:10 GMT, Mahendra Chhipa <mchhipa at openjdk.org> wrote:

>> Updated following tests to use ProcessTools methods:
>>  test/jdk/java/lang/Thread/UncaughtExceptionsTest.java
>>  test/jdk/java/lang/annotation/LoaderLeakTest.java
>>  test/jdk/java/rmi/reliability/benchmark/bench/rmi/Main.java
>>  test/jdk/java/time/nontestng/java/time/chrono/HijrahConfigTest.java
>>  test/jdk/javax/naming/spi/providers/InitialContextTest.java
>
> Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Implemented the review comments.

Hello Mahendra, thank you for the updates. There's one review comment I've added about a stray code comment, other than that the changes look OK to me.

I haven't checked which tiers these tests reside in. Before integrating, it would be good to run the specific tiers (or tier1, tier2 and tier3) and make sure these changes don't cause issues.

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18602#pullrequestreview-1993707442


More information about the core-libs-dev mailing list