RFR: 8329331: Intrinsify Unsafe::setMemory [v13]

Scott Gibbons sgibbons at openjdk.org
Fri Apr 12 13:46:46 UTC 2024


On Fri, 12 Apr 2024 00:14:29 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:

>> Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Addressing yet more review comments
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_arraycopy.cpp line 2504:
> 
>> 2502:     Label L_exit, L_fillQuadwords, L_fillDwords, L_fillBytes;
>> 2503: 
>> 2504:     setup_arg_regs(3);
> 
> A comment stating the placement of dest, size, and byteVal after call to setup_arg_regs() would be very helpful.

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18555#discussion_r1562562649


More information about the core-libs-dev mailing list