RFR: 8319516: AIX System::loadLibrary needs support to load a shared library from an archive object [v13]

Martin Doerr mdoerr at openjdk.org
Mon Apr 15 14:11:52 UTC 2024


On Mon, 8 Apr 2024 10:27:40 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Suchismith Roy has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - update tests
>>  - update tests
>>  - update tests
>
> src/java.base/aix/classes/jdk/internal/loader/ClassLoaderHelper.java line 40:
> 
>> 38:     * This method returns false so that loading of shared library continues if
>> 39:     * libname.so is not present.
>> 40:     */
> 
> The '*' should be in the same column. Please compare to ClassLoaderHelper.java for other OSs.

'*' should are in the same column, now, but it is still not the same coding style as in other files. Why can't you do it exactly like https://github.com/openjdk/jdk/blob/273df6286a9cc4dcef4cd339234206b2ad922386/src/java.base/unix/classes/jdk/internal/loader/ClassLoaderHelper.java#L43 ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17945#discussion_r1565857910


More information about the core-libs-dev mailing list