RFR: 8324651: Compiler Implementation for Derived Record Creation (Preview) [v10]
Vicente Romero
vromero at openjdk.org
Mon Apr 15 21:26:02 UTC 2024
On Tue, 9 Apr 2024 09:28:23 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:
>> This is a patch for javac, that adds the Derived Record Creation expressions. The current draft specification for the feature is:
>> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>>
>> The current CSR is here:
>> https://bugs.openjdk.org/browse/JDK-8328637
>>
>> The patch is mostly straightforward, with two notable changes:
>> - there is a new `ElementKind.COMPONENT_LOCAL_VARIABLE`, as the specification introduces this term, and it seems consistent with `ElementKind.BINDING_VARIABLE` that was introduced some time ago.
>> - there are a bit broader changes in `Flow`, to facilitate the introduction of variables without an explicit declaration for definite assignment and effectively final computation.
>
> Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
>
> Reflecting review feedback:
> - reverting unnecessary changes in TransPatterns
> - moving the patters/withers/Model test to a more appropriate place
lgtm
-------------
Marked as reviewed by vromero (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18509#pullrequestreview-2002193598
More information about the core-libs-dev
mailing list