RFR: 8329331: Intrinsify Unsafe::setMemory [v14]

Sandhya Viswanathan sviswanathan at openjdk.org
Mon Apr 15 22:35:02 UTC 2024


On Fri, 12 Apr 2024 16:47:58 GMT, Scott Gibbons <sgibbons at openjdk.org> wrote:

>> This code makes an intrinsic stub for `Unsafe::setMemory` for x86_64.  See [this PR](https://github.com/openjdk/jdk/pull/16760) for discussion around this change.
>> 
>> Overall, making this an intrinsic improves overall performance of `Unsafe::setMemory` by up to 4x for all buffer sizes.
>> 
>> Tested with tier-1 (and full CI).  I've added a table of the before and after numbers for the JMH I ran (`MemorySegmentZeroUnsafe`).
>> 
>> [setMemoryBM.txt](https://github.com/openjdk/jdk/files/14808974/setMemoryBM.txt)
>
> Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Even more review comments

src/hotspot/cpu/x86/stubGenerator_x86_64_arraycopy.cpp line 2692:

> 2690:       __ BIND(L_fillBytes);
> 2691:     }
> 2692: #ifdef MUSL_LIBC

The code in #Ifdef MUSL_LIBC can be removed as we are not using the libc call in the #else path.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18555#discussion_r1563287878


More information about the core-libs-dev mailing list