RFR: 8310994: Add JFR event for selection operations [v2]
Alan Bateman
alanb at openjdk.org
Tue Apr 16 08:12:45 UTC 2024
On Mon, 26 Feb 2024 14:17:09 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> src/jdk.jfr/share/classes/jdk/jfr/events/SelectorSelectEvent.java line 44:
>>
>>> 42: @Label("SelectionKey Count")
>>> 43: @Description("Number of channels ready for I/O or added to ready set")
>>> 44: public int selectionKeyCount;
>>
>> same here
>
> Thanks for adding the timeout.
I think the description should be changed to say that it's the number of unique keys updated, nothing more. This covers the selection operations that add or update keys to the selected key set, and also the selection operations that update keys and invoke an action to consume.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16710#discussion_r1566922400
More information about the core-libs-dev
mailing list