RFR: 8310994: Add JFR event for selection operations [v7]

Erik Gahlin egahlin at openjdk.org
Tue Apr 16 09:57:43 UTC 2024


On Mon, 15 Apr 2024 21:37:15 GMT, Tim Prinzing <tprinzing at openjdk.org> wrote:

>> Added mirror event with static methods: jdk.internal.event.SelectionEvent that provides the duration of select calls and the count of how many keys are available.
>> 
>> Emit the event from SelectorImpl::lockAndDoSelect
>> 
>> Test at jdk.jfr.event.io.TestSelectionEvents
>
> Tim Prinzing has updated the pull request incrementally with one additional commit since the last revision:
> 
>   cleanup of annotations

src/jdk.jfr/share/classes/jdk/jfr/events/SelectorSelectEvent.java line 43:

> 41: 
> 42:     @Label("Timeout Value")
> 43:     @Description("time to block, or zero to block indefinitely")

Sentence should start with a capital letter. I think "Timeout" is sufficient, no need to have "Value" in the label.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16710#discussion_r1567082204


More information about the core-libs-dev mailing list