RFR: 8329862: GetApplicationHome and GetApplicationHomeFromDll enhance jli tracing

Matthias Baesken mbaesken at openjdk.org
Tue Apr 16 14:32:01 UTC 2024


On Tue, 16 Apr 2024 09:09:00 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> We have already good JLI tracing capabilities. But GetApplicationHome and GetApplicationHomeFromDll lack some tracing and should be enhanced.
>
> src/java.base/windows/native/libjli/java_md.c line 326:
> 
>> 324:     }
>> 325: 
>> 326:     JLI_TraceLauncher("GetJREPath - attempt to get JRE location from shared lib of the image\n");
> 
> Maybe add a trace also in the USE_REGISTRY_LOOKUP section

Hi Christoph, seems the USE_REGISTRY_LOOKUP is currently unused  (at least without additional defines that are not present usually) 

src/java.base/windows/native/libjli/java_md.c:52:#ifdef USE_REGISTRY_LOOKUP
src/java.base/windows/native/libjli/java_md.c:333:#ifdef USE_REGISTRY_LOOKUP


I am not sure if this even works any more.  Maybe Alan could comment on this ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18699#discussion_r1567466784


More information about the core-libs-dev mailing list