RFR: 8327964: Simplify BigInteger.implMultiplyToLen intrinsic [v5]

Dean Long dlong at openjdk.org
Wed Apr 17 19:36:01 UTC 2024


On Wed, 17 Apr 2024 12:35:54 GMT, Yudi Zheng <yzheng at openjdk.org> wrote:

>> Moving array construction within BigInteger.implMultiplyToLen intrinsic candidate to its caller simplifies the intrinsic implementation in JIT compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional commit since the last revision:
> 
>   address comment.

src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 4670:

> 4668:     const Register tmp5  = r15;
> 4669:     const Register tmp6  = r16;
> 4670:     const Register tmp7  = r17;

Why not minimize changes and continue to use r5 for tmp0?  I see no need for r17 or to reassign all the other tmp registers.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18226#discussion_r1569401544


More information about the core-libs-dev mailing list