RFR: 8294960: Convert java.base/java.lang.invoke package to use the Classfile API to generate lambdas and method handles [v6]

[Sergey Kuksenko]

On Wed, 17 Apr 2024 15:21:32 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> java.base java.lang.invoke package heavily uses ASM to generate lambdas and method handles.
>> 
>> This patch converts ASM calls to Classfile API.
>> 
>> This PR is continuation of https://github.com/openjdk/jdk/pull/12945
>> 
>> Any comments and suggestions are welcome.
>> 
>> Please review.
>> 
>> Thank you,
>> Adam
>
> Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:
> 
>  - applied suggested changes
>  - Merge branch 'master' into JDK-8294960-invoke
>  - Reversion of ClassBuilder changes
>  - Merge branch 'master' into JDK-8294960-invoke
>  - Apply suggestions from code review
>    
>    Co-authored-by: liach <7806504+liach at users.noreply.github.com>
>  - Apply suggestions from code review
>    
>    Co-authored-by: liach <7806504+liach at users.noreply.github.com>
>  - added missing comment
>  - fixed InnerClassLambdaMetafactory for hidden caller classes
>  - performance improvements
>  - consolidation of descriptors handling
>  - ... and 2 more: https://git.openjdk.org/jdk/compare/983bd2da...304054b9

Sorry, but I am afraid we don't have benchmarks targeting lambdas startup.

________________________________________
From: Mandy Chung ***@***.***>
Sent: Wednesday, April 17, 2024 9:32 AM
To: openjdk/jdk
Cc: Sergey Kuksenko; Mention
Subject: [External] : Re: [openjdk/jdk] 8294960: Convert java.base/java.lang.invoke package to use the Classfile API to generate lambdas and method handles (PR #17108)

@cl4es<https://urldefense.com/v3/__https://github.com/cl4es__;!!ACWV5N9M2RV99hQ!JX5yZ-c9NW3SFSXgKWYc1Kxk2V17ToAhlQI5UDK7A2MWjHAXtLYugARjgiqw_ohDi3CY7GPh1B2YJuwCbeQ-huf92_-fGQ$> and @kuksenko<https://urldefense.com/v3/__https://github.com/kuksenko__;!!ACWV5N9M2RV99hQ!JX5yZ-c9NW3SFSXgKWYc1Kxk2V17ToAhlQI5UDK7A2MWjHAXtLYugARjgiqw_ohDi3CY7GPh1B2YJuwCbeQ-hudN3iK0Ug$> can you advice what performance benchmarks to run to approve this change?

—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/17108*issuecomment-2061720876__;Iw!!ACWV5N9M2RV99hQ!JX5yZ-c9NW3SFSXgKWYc1Kxk2V17ToAhlQI5UDK7A2MWjHAXtLYugARjgiqw_ohDi3CY7GPh1B2YJuwCbeQ-hudSbyeARA$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AA72M642PZCTBSXMJQ57543Y52P2NAVCNFSM6AAAAABAUY4GQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRRG4ZDAOBXGY__;!!ACWV5N9M2RV99hQ!JX5yZ-c9NW3SFSXgKWYc1Kxk2V17ToAhlQI5UDK7A2MWjHAXtLYugARjgiqw_ohDi3CY7GPh1B2YJuwCbeQ-hueMj9Y5wA$>.
You are receiving this because you were mentioned.Message ID: ***@***.***>

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17108#issuecomment-2062338565