RFR: 8329862: GetApplicationHome and GetApplicationHomeFromDll enhance jli tracing [v3]

Thu Apr 18 06:58:57 UTC 2024

On Thu, 18 Apr 2024 06:31:03 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Hi Christoph, seems the USE_REGISTRY_LOOKUP is currently unused  (at least without additional defines that are not present usually) 
>> 
>> src/java.base/windows/native/libjli/java_md.c:52:#ifdef USE_REGISTRY_LOOKUP
>> src/java.base/windows/native/libjli/java_md.c:333:#ifdef USE_REGISTRY_LOOKUP
>> 
>> 
>> I am not sure if this even works any more.  Maybe Alan could comment on this ?
>
> @MBaesken I checked into the building with -DUSE_REGISTRY_LOOKUP as that compiled in code that the Oracle installer needed when it copied java.exe to somewhere. This is indeed left over code and can be removed from java_md.c.

Hi Alan, thanks for checking this !
I removed the USE_REGISTRY_LOOKUP usages.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18699#discussion_r1570109527