RFR: 8328481: Implement Module Imports [v9]

Jan Lahoda jlahoda at openjdk.org
Thu Apr 18 12:11:20 UTC 2024


On Thu, 18 Apr 2024 10:47:11 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updating JEP number and caption.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties line 3541:
> 
>> 3539: # 0: symbol, 1: symbol
>> 3540: compiler.err.import.module.does.not.read=\
>> 3541:     {1} module does not read: {0}
> 
> shouldn't it be `module {1} does not read: {0}` ? Also, maybe worth reordering the params?

Thanks! Fixed:
https://github.com/openjdk/jdk/pull/18614/commits/846b038ed8145ede9c419daddedb794a429dafac

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18614#discussion_r1570597292


More information about the core-libs-dev mailing list