RFR: 8329138: Convert JFR FileForceEvent to static mirror event [v5]

[Daniel Fuchs]

On Wed, 17 Apr 2024 01:34:07 GMT, Tim Prinzing <tprinzing at openjdk.org> wrote:

>> Currently the JFR event FileForceEvent is generated by instrumenting the sun.nio.ch.FileChannelImpl class. This needs to be changed to use the newer mirror events with static methods.
>> 
>> Added the event at jdk.internal.event.FileForceEvent, and changed jdk.jfr.events.FileForceEvent to be a mirror event.
>> 
>> Updated FileChannelImpl to use the jdk internal event static methods, and removed the force() method from FileChannelImplInstrumentor.
>> 
>> Uses the existing tests.
>
> Tim Prinzing has updated the pull request incrementally with one additional commit since the last revision:
> 
>   test file local to test

Sorry - just noticed this comment has been pending for a few days...

src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/JDKEvents.java line 66:

> 64:         FileWriteEvent.class,
> 65:         SocketReadEvent.class,
> 66:         SocketWriteEvent.class,

I'm guessing that this change which remove these two event classes is a drive-by-cleanup that should actually have been done with some previous fix in this area?
Just wanted to double check it was intended as it doesn't seem to be related to file events.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18542#pullrequestreview-2006152864
PR Review Comment: https://git.openjdk.org/jdk/pull/18542#discussion_r1568907662