RFR: 8329862: GetApplicationHome and GetApplicationHomeFromDll enhance jli tracing [v3]

Christoph Langer clanger at openjdk.org
Fri Apr 19 09:23:58 UTC 2024


On Thu, 18 Apr 2024 06:57:05 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> We have already good JLI tracing capabilities. But GetApplicationHome and GetApplicationHomeFromDll lack some tracing and should be enhanced.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove obsolete USE_REGISTRY_LOOKUP usages

src/java.base/unix/native/libjli/java_md_common.c line 85:

> 83:     const char *execname = GetExecName();
> 84:     if (execname != NULL) {
> 85:         JLI_TraceLauncher("Launcher executable path is %s\n", execname);

This trace seems a bit unsymmetric to its Windows counterpart. Maybe it should be left out here, too, since there is tracing in GetJREPath.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18699#discussion_r1572086726


More information about the core-libs-dev mailing list