RFR: 8329760: Add indexOf(Predicate<? super E> filter) to java..util.List interface [v2]

Chen Liang liach at openjdk.org
Fri Apr 19 11:47:58 UTC 2024


On Fri, 19 Apr 2024 11:33:59 GMT, Evemose <duke at openjdk.org> wrote:

>> Adding (default) methods to `List` would have significant compatibility ramifications. Also, the PR needs to contain significant testing of the new proposed methods.
>
> @minborg Sorry to bother you with this kind of question, but i cant manage to find where exactly and how I can file CSR review request. Could you help me out?

@Evemose CSR requests can only be filed by users who have a JBS account. I am glad to help you file one, but before that, you need to ensure that the API surface (the public method/fields' names, modifiers, types, and javadocs) are all finalized and won't change.

The CSR looks like this:
Summary: A concise summary about the changes, like "Add findIndex(Predicate) to List"
Problem: Description of the problem, as in why this CSR is needed
Solution: The solution to the said problem, i.e. what your task did
Specification: The git diff, but you only need to include changes to public method/field/classes' names, modifiers, types, and javadocs; you don't need to include any implementation code changes
Also, you might include things like "alternatives" describing alternative approaches and why you elect not to choose them, etc.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18639#issuecomment-2066402038


More information about the core-libs-dev mailing list