RFR: 8328481: Implement Module Imports [v11]
Jan Lahoda
jlahoda at openjdk.org
Fri Apr 19 13:17:18 UTC 2024
> This is an implementation of JEP JDK-8315129: Module Import Declarations (Preview). Please see the JEP for details:
> https://bugs.openjdk.org/browse/JDK-8315129
>
> It is mostly straightforward - the module imports are parsed, and then expanded to import-on-demand in `TypeEnter`.
> There is a few notable aspects, however:
> - the AST node for import (`JCImport`) is holding the imported element as a field access, because so far, the imported element always had to have a '.' (even for import-on-demand). But for module imports, it is permissible to import from a module whose name does not have a dot (`import module m;`). The use of field access for ordinary import seems very useful, so I preferred to keep that, and created a new internal-only AST node for module imports. There is still only one public API AST node/interface, so this is purely an implementation choice.
> - JShell now supports module imports as well; and the default, implicit, script is changed to use it to import all of `java.base` if preview is enabled. It is expected that the default would be changed if/when the module imports feature is finalized.
Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
Adding test for ImportTree.isModule, as suggested.
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/18614/files
- new: https://git.openjdk.org/jdk/pull/18614/files/846b038e..cbc363ab
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=18614&range=10
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=18614&range=09-10
Stats: 135 lines in 1 file changed: 135 ins; 0 del; 0 mod
Patch: https://git.openjdk.org/jdk/pull/18614.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/18614/head:pull/18614
PR: https://git.openjdk.org/jdk/pull/18614
More information about the core-libs-dev
mailing list