RFR: 8329331: Intrinsify Unsafe::setMemory [v23]

[Scott Gibbons]

On Fri, 19 Apr 2024 20:53:31 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_arraycopy.cpp line 2550:
> 
>> 2548: 
>> 2549:   // If zero, then we're done
>> 2550:   __ jccb(Assembler::zero, L_exit);
> 
> Code in `generate_unsafe_setmemory()` uses long jumps to `L_exit` but here you use short. Why?

Ah - the original code (3 iterations ago) was about 10 bytes too long for a short jump.  It's short enough now.  Changed.

> src/hotspot/share/opto/runtime.cpp line 785:
> 
>> 783:   fields[argp++] = TypePtr::NOTNULL;        // dest
>> 784:   fields[argp++] = TypeX_X;                 // size
>> 785:   LP64_ONLY(fields[argp++] = Type::HALF);  // size
> 
> Nit: align `/`

Done

> src/hotspot/share/utilities/copy.hpp line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2003, 2024, Oracle and/or its affiliates. All rights reserved.
> 
> You forgot to undo year change in this file.

Yup. Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18555#discussion_r1573006432
PR Review Comment: https://git.openjdk.org/jdk/pull/18555#discussion_r1573014982
PR Review Comment: https://git.openjdk.org/jdk/pull/18555#discussion_r1573015145