RFR: 8329593: Drop adjustments to target parallelism when virtual threads do I/O on files opened for buffered I/O [v2]
Alan Bateman
alanb at openjdk.org
Tue Apr 23 08:11:30 UTC 2024
On Tue, 23 Apr 2024 08:04:54 GMT, Viktor Klang <vklang at openjdk.org> wrote:
>> Alan Bateman has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>>
>> - Merge
>> - Sync up from loom repo, update copyright headers
>> - Merge
>> - Merge
>> - Initial commit
>
> src/java.base/share/classes/java/io/FileInputStream.java line 211:
>
>> 209: * @param name the name of the file
>> 210: */
>> 211: private void open(String name) throws FileNotFoundException {
>
> If method such as this is private, and only delegates to the 0-suffixed native method, would't it be better to just call the 0-suffixed method directly?
Historically these native methods were wrapped in order to support instrumentation, I didn't want to touch in this PR.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18598#discussion_r1575831563
More information about the core-libs-dev
mailing list