RFR: 8329760: Add indexOf(Predicate<? super E> filter) to java.util.List interface [v2]

Evemose duke at openjdk.org
Tue Apr 23 13:54:43 UTC 2024


On Fri, 19 Apr 2024 12:10:34 GMT, Chen Liang <liach at openjdk.org> wrote:

>> @minborg Sorry to bother you with this kind of question, but i cant manage to find where exactly and how I can file CSR review request. Could you help me out?
>
> @Evemose Please revert formatting changes in existing classes. Unfortunately there's no single code style across all of JDK, but you shouldn't try to format code/methods that's not touched by your new method addition.

@liach Seems like discussion in mails has came to some conclusion (or people just arent interested in it anymore). Therefore, i think its time to file for csr. Here is a draft request text, but Im not sure how to fill in some fields:
Summary: Add findIndex(Predicate) and findLastIndex(Predicate) to List
Problem: Modification of java.utilList interface by adding findIndex(Predicate) and findLastIndex(Predicate) methods might introduce behavioural or byteecode incompatibilities
Solution: // dont know what to write here tbh
Specification: // do i have to paste changed code here, or provide links, or what?
Alternatives: syntax line indexOf(Predicate) and lastIndexOf(Predicate) was concidered, but discarded due to behavioural incompatibilities with invokation indexOf(null)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18639#issuecomment-2072079213


More information about the core-libs-dev mailing list