RFR: 8329862: GetApplicationHome and GetApplicationHomeFromDll enhance jli tracing [v4]

[Alan Bateman]

On Mon, 22 Apr 2024 11:57:19 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Hi, any additional comments / reviews ?
>> Thanks Matthias
>
>> Hi, any additional comments / reviews ? Thanks Matthias
> 
> It still looks like left over trace messages from a debugging session, need to think about about what tracing make sense here.

> @AlanBateman If this is not acceptable to add, I must once again iterate my question: What is the use case for the tracing functionality then?

The tracing was mostly for the options and timing when it was originally added.  I don't object to expanding the tracing. The issue is that the proposed additions are inconsistent with the existing trace messages, e.g.  GetJREPath's existing trace messages use "JRE path", the proposed messages switch to "JRE location".

BTW:  the vestiges of the "JRE" should really be removed. The GetJREPath function has no business looking for jre/lib as that location does not exist since JDK 9.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18699#issuecomment-2072415065