RFR: 8329760: Add indexOf(Predicate<? super E> filter) to java.util.List interface [v12]

Evemose duke at openjdk.org
Wed Apr 24 08:32:37 UTC 2024


On Tue, 23 Apr 2024 20:30:22 GMT, ExE Boss <duke at openjdk.org> wrote:

>> Evemose has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Added Objects import to sun List
>>  - Replaced on-demand import in com.sun....List
>>  - added non-null assertions
>
> src/java.base/share/classes/java/util/ArrayList.java line 380:
> 
>> 378:     }
>> 379: 
>> 380:     int findLastIndexInRange(Predicate<? super E> filter, int start, int end) {
> 
> Suggestion:
> 
>     private int findLastIndexInRange(Predicate<? super E> filter, int start, int end) {

Yeah i though about it but indexOfRange arent private here so either there is a point in it or its just legacy without any particular meaning

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18639#discussion_r1577501340


More information about the core-libs-dev mailing list