RFR: 8330755: ProblemList files have entries referring to non-existent tests [v2]
Doug Simon
dnsimon at openjdk.org
Wed Apr 24 10:50:44 UTC 2024
> This PR adds a check for the format of ProblemList files and ensures they only have entries referring to existing tests.
>
> The cleanups in the second commit of this PR were done based on the output of `CheckProblemLists`:
>
>> make test TEST=build/problemLists/CheckProblemLists.java
> ...
> STDOUT:
> Checking /Users/dnsimon/dev/jdk-jdk/open/test/hotspot/jtreg/ProblemList-Virtual.txt
> Checking /Users/dnsimon/dev/jdk-jdk/open/test/hotspot/jtreg/ProblemList-Xcomp.txt
> Checking /Users/dnsimon/dev/jdk-jdk/open/test/hotspot/jtreg/ProblemList-generational-zgc.txt
> Checking /Users/dnsimon/dev/jdk-jdk/open/test/hotspot/jtreg/ProblemList-zgc.txt
> Checking /Users/dnsimon/dev/jdk-jdk/open/test/hotspot/jtreg/ProblemList.txt
> Checking /Users/dnsimon/dev/jdk-jdk/open/test/jaxp/ProblemList.txt
> Checking /Users/dnsimon/dev/jdk-jdk/open/test/jdk/ProblemList-Virtual.txt
> Checking /Users/dnsimon/dev/jdk-jdk/open/test/jdk/ProblemList-Xcomp.txt
> Checking /Users/dnsimon/dev/jdk-jdk/open/test/jdk/ProblemList-generational-zgc.txt
> Checking /Users/dnsimon/dev/jdk-jdk/open/test/jdk/ProblemList-zgc.txt
> Checking /Users/dnsimon/dev/jdk-jdk/open/test/jdk/ProblemList.txt
> Checking /Users/dnsimon/dev/jdk-jdk/open/test/langtools/ProblemList.txt
> Checking /Users/dnsimon/dev/jdk-jdk/open/test/lib-test/ProblemList.txt
> Checked 13 problem list files
> Test roots:
> /Users/dnsimon/dev/jdk-jdk/open/test/jdk
> /Users/dnsimon/dev/jdk-jdk/open/test/lib-test
> /Users/dnsimon/dev/jdk-jdk/open/test/failure_handler/test
> /Users/dnsimon/dev/jdk-jdk/open/test/jaxp
> /Users/dnsimon/dev/jdk-jdk/open/test/langtools
> /Users/dnsimon/dev/jdk-jdk/open/test/hotspot/jtreg
> Following errors found:
> /Users/dnsimon/dev/jdk-jdk/open/test/hotspot/jtreg/ProblemList.txt:174: vmTestbase/gc/lock/jni/jnilock002/TestDescription.java does not exist under any test root
> vmTestbase/gc/lock/jni/jnilock002/TestDescription.java 8192647 generic-all
>
> /Users/dnsimon/dev/jdk-jdk/open/test/jdk/ProblemList-Virtual.txt:77: TestAndIssue[test=java/util/Properties/StoreReproducibilityTest.java, issueId=0000000] duplicates /Users/dnsimon/dev/jdk-jdk/open/test/jdk/ProblemList-Virtual.txt:76
> java/util/Properties/StoreReproducibilityTest.java 0000000 generic-all
>
> /Users/dnsimon/dev/jdk-jdk/open/test/jdk/ProblemList.txt:516: java/lang/management/MemoryMXBean/PendingAllGC.sh does not exist under any test root
> java/lang/management/MemoryMXBean/PendingAllGC.sh 8158837 generic-all
>
> /Users/dnsimon/dev/jdk-jdk/open/test/jdk/ProblemList.txt:667: javax/swing/JFi...
Doug Simon has updated the pull request incrementally with one additional commit since the last revision:
removed CheckProblemLists.java
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/18879/files
- new: https://git.openjdk.org/jdk/pull/18879/files/49a1a58e..22ffae05
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=18879&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=18879&range=00-01
Stats: 211 lines in 1 file changed: 0 ins; 211 del; 0 mod
Patch: https://git.openjdk.org/jdk/pull/18879.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/18879/head:pull/18879
PR: https://git.openjdk.org/jdk/pull/18879
More information about the core-libs-dev
mailing list