RFR: 8327247: C2 uses up to 2GB of RAM to compile complex string concat in extreme cases [v7]
Claes Redestad
redestad at openjdk.org
Thu Apr 25 14:20:35 UTC 2024
On Wed, 24 Apr 2024 10:05:27 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>>> I really wish this change was not done with ClassFile API, but with a simple bundled ASM, so it would be easily backportable, if we decide to. It does not look like CFA buys us a lot here readability/complexity wise: [d99b159](https://github.com/openjdk/jdk/commit/d99b1596c5ca57b110c1db88be430c6c54c3d599)
>>
>> I would be open to splitting out and pushing the ASM version first and do this CFA port as a follow-up.
>
>> > I really wish this change was not done with ClassFile API, but with a simple bundled ASM, so it would be easily backportable, if we decide to. It does not look like CFA buys us a lot here readability/complexity wise: [d99b159](https://github.com/openjdk/jdk/commit/d99b1596c5ca57b110c1db88be430c6c54c3d599)
>>
>> I would be open to splitting out and pushing the ASM version first and do this CFA port as a follow-up.
>
> That would be good, thanks.
@shipilev @mlchung opened new PR #18953 for pushing the ASM-based version. Adapted applicable code changes from this PR so it should be equivalent in behavior.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18690#issuecomment-2077319721
More information about the core-libs-dev
mailing list