RFR: 8327247: C2 uses up to 2GB of RAM to compile complex string concat in extreme cases [v2]

[Claes Redestad]

On Thu, 25 Apr 2024 16:46:25 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Claes Redestad has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove accidental use of java.lang.classfile
>
> src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java line 1059:
> 
>> 1057:      */
>> 1058:     private static final class SimpleStringBuilderStrategy {
>> 1059:         static final int CLASSFILE_VERSION = ClassFile.latestMajorVersion();
> 
> Still breaks backward ASM port, we should use a fixed version like 52 for JAVA_8 and convert to latest only in the CF conversion later.

Good catch. In the code I am [reviving](https://github.com/cl4es/jdk/commit/36c4b11bc6cf5a008d5935934aa75f2d2bbe6a23#diff-1339c269a3729d849799d29a7431ccd508a034ced91c1796b952795396843891L771) this field was simply set to `52`. Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18953#discussion_r1580047931