RFR: 8327791: Optimization for new BigDecimal(String) [v10]

Joe Darcy darcy at openjdk.org
Fri Apr 26 02:07:39 UTC 2024


On Tue, 19 Mar 2024 19:32:10 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> I think splitting `CharArraySequence` into two versions is somewhat dubious as more observable types at call sites may mean the performance gain in targeted micros is lost. How much of an improvement did you observe from this? Again the `char[]` constructors is probably less performance sensitive than the others.
>
>> @cl4es @jddarcy All feedback has been fixed, can it be integrated?
> 
> Hello @wenshao ,
> 
> This change will need additional review from myself or others who maintain BigDecimal before it can be integrated.

> @jddarcy Sorry for the pings, Can you review this PR for me?

Hi @wenshao ,
Can you provide some additional context about the benefits of this change beyond the micro/nano bechmark results that have been discussed. For example, is there interesting workload the change improves, etc.? Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18177#issuecomment-2078497794


More information about the core-libs-dev mailing list